Template construction of Pool elements #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pool class is used by verona-rt. The recent changes made this less nice to consume as an API. This change makes the construction logic a template parameter to the Pool. This enables standard allocation to be used from Verona.
nwf
reviewed
Sep 29, 2023
Pool::acquire took a list of parameters to initialise the object that it constructed. But if this was serviced from the pool, the parameter would be ignored. This is not an ideal API. This PR removes the ability to pass a parameter.
nwf-msr
reviewed
Oct 3, 2023
| @@ -621,8 +621,7 @@ namespace snmalloc | |||
| template< | |||
| typename Config_ = Config, | |||
| typename = std::enable_if_t<Config_::Options.CoreAllocOwnsLocalState>> | |||
| CoreAllocator(Range<capptr::bounds::Alloc>& spare, LocalCache* cache) | |||
| : attached_cache(cache) | |||
| CoreAllocator(Range<capptr::bounds::Alloc>& spare) | |||
There was a problem hiding this comment.
This is going to leave attached_cache nullptr "more often" after construction (I guess you could always have passed in nullptr for the 2nd arg). Are we guaranteed that attach() is called before flush() or before handle_message_queue_inner() decides to post()?
nwf-msr
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pool class is used by verona-rt. The recent changes made this less nice to consume as an API.
This change makes the construction logic a template parameter to the Pool. This enables standard allocation to be used from Verona.
Fixes #603