Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable client meta-data #662

Merged
merged 26 commits into from
Jun 13, 2024
Merged

Configurable client meta-data #662

merged 26 commits into from
Jun 13, 2024

Conversation

mjp41
Copy link
Member

@mjp41 mjp41 commented Jun 11, 2024

This addresses issue #661.

This provide a way to configure snmalloc to provide per object meta-data that is out of band. This can be used to provide different mitigations on top of snmalloc, such as storing memory tags in a compressed form, or provide a miracle pointer like feature.

This commit adds the storage of client meta to the configuration.
This is not exposed in this commit.
This provides a way to access the client meta data for an object.
@mjp41 mjp41 requested a review from nwf-msr June 11, 2024 14:37
Copy link
Contributor

@nwf-msr nwf-msr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments having glanced only at the first commit. Sorry if they're obviated by later changes!

src/snmalloc/mem/corealloc.h Outdated Show resolved Hide resolved
src/snmalloc/mem/corealloc.h Outdated Show resolved Hide resolved
src/snmalloc/backend_helpers/commonconfig.h Outdated Show resolved Hide resolved
src/test/func/client_meta/client_meta.cc Show resolved Hide resolved
src/test/func/miracle_ptr/miracle_ptr.cc Show resolved Hide resolved
src/snmalloc/mem/metadata.h Outdated Show resolved Hide resolved
@mjp41 mjp41 enabled auto-merge (squash) June 13, 2024 10:14
@mjp41 mjp41 mentioned this pull request Jun 13, 2024
@mjp41 mjp41 merged commit 2a7eabe into microsoft:main Jun 13, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants