Rework CI #674
Merged
Rework CI #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwf-msr
force-pushed
the
202409-ci-macos
branch
3 times, most recently
from
1403119
to
c48ad12
Compare
nwf-msr
force-pushed
the
202409-ci-macos
branch
from
c48ad12
to
21a1568
Compare
mjp41
reviewed
Sep 10, 2024
.github/workflows/main.yml
Outdated
| # after trying to install Python as a dependency of ninja because | ||
| # 2to3 exists. As a quick hack, delete it first. This should be | ||
| # removed once the homebrew install is fixed. | ||
| run: "rm -f /usr/local/bin/2to3 ; brew update && brew install ninja" | ||
|
|
||
| - uses: mjp41/workaround8649@c8550b715ccdc17f89c8d5c28d7a48eeff9c94a8 |
There was a problem hiding this comment.
I don't think this is needed on Mac OS
There was a problem hiding this comment.
OK, let's give that a shot. :)
There was a problem hiding this comment.
Looks like you're right. :)
- Split ubuntu and macos CI actions, even though they use very similar steps - Remove macos-11, keep -12, and add -14 - Have all macos platforms build with and without C++17 - Remove duplicated dependency lines in ubuntu matrix entries; push this down to the steps - Ensure that all added ubuntu matrix tuples have non-empty build-type - Add all jobs to all-checks' "needs:" to ensure we wait for everything
nwf-msr
force-pushed
the
202409-ci-macos
branch
from
21a1568
to
3352aa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.