Remove some unneeded headers #680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjp41
force-pushed
the
20240924-includes
branch
2 times, most recently
from
f1e86d7
to
f88be6f
Compare
This removes some unneeded headers from the headers.
This stack allocates and copies a c-string to replace the calls to std::string.
mjp41
force-pushed
the
20240924-includes
branch
from
f88be6f
to
63cfb65
Compare
SamuelMarks
reviewed
Sep 24, 2024
src/snmalloc/ds_core/redblacktree.h
Outdated
| auto s_indent = std::string(indent); | ||
| print(get_dir(true, curr), (s_indent + "|").c_str(), depth + 1); | ||
| print(get_dir(false, curr), (s_indent + " ").c_str(), depth + 1); | ||
| char s_indent[128]; |
There was a problem hiding this comment.
Why 128? - Also you might want to use a scoped constant, like enum { size = 128 }; char s_indent[size]
There was a problem hiding this comment.
@SamuelMarks thanks for your code review. I've added a comment to explain the bound, and made a constexpr for the constant.
mjp41
force-pushed
the
20240924-includes
branch
from
9eb7735
to
ac23f54
Compare
mjp41
requested review from
SamuelMarks and
nwf
and removed request for
SamuelMarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #670.