Merge pull request #1741 from microsoft/dev/gcampbell/policheck

update policheck
microsoft · May 6, 2024 · 6f24815 · 6f24815
2 parents f745371 + c497d2f
commit 6f24815
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -34,6 +34,13 @@ jobs:
         with:
           node-version: 16.x
 
+      # On new macos-latest machines, Python 3.9+ is used, and it's causing issues with binding.gyp
+      - name: Use Python 3.8
+        if: ${{ matrix.os == 'macos-latest' }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: 3.8
+
       - name: Windows setup
         if: ${{ matrix.os == 'windows-latest' }}
         run: |

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -53,6 +53,12 @@ extends:
       name: VSEngSS-MicroBuild2022-1ES
     sdl:
       sourceAnalysisPool: VSEngSS-MicroBuild2022-1ES
+      tsa:
+        enabled: true
+        GdnPublishTsaOnboard: true
+        GdnPublishTsaConfigFile: $(Build.SourcesDirectory)\build\tsa.gdntsa
+      policheck:
+        enabled: true
       spotBugs:
         enabled: false # Turn this off, this isn't java.
     customBuildTags:

diff --git a/build/build.yml b/build/build.yml
@@ -13,14 +13,6 @@ jobs:
   variables:
     TeamName: C++ Cross Platform and Cloud
   templateContext:
-    sdl:
-    ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
-      tsa:
-        enabled: true
-        GdnPublishTsaOnboard: true
-        GdnPublishTsaConfigFile: $(Build.SourcesDirectory)\build\tsa.gdntsa
-      policheck:
-        enabled: true
     outputs:
     - output: pipelineArtifact
       displayName: 'Publish extension VSIXes as artifact'