Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add timestamps to logs #4057

Open
JamieStM opened this issue Sep 10, 2024 · 0 comments
Open

Suggestion: Add timestamps to logs #4057

JamieStM opened this issue Sep 10, 2024 · 0 comments
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: UI more votes needed We currently are de-prioritizing this issue until more community up-votes are provided
Milestone

Comments

@JamieStM
Copy link

JamieStM commented Sep 10, 2024

Brief Issue Summary

It's helpful to have timestamps associated with the cmake build log, for example when building vcpkg dependencies that may take a long time. We can do that for ninja via its configuration, but for cmake it's not as simple. I'm able to do this by modifying cmaketools' dist.js on every update and changing the line

            this._channel.appendLine(user_message);

to

            this._channel.appendLine(raw_message);

But I figure that if it's helpful for me, then maybe it would be helpful for someone else.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

I think the change could be made with a simple bool flag, inserted here:

const trace = vscode.workspace.getConfiguration('cmake').get('enableTraceLogging', false);

e.g.

const debugInOutput = vscode.workspace.getConfiguration('cmake').get('enableDebugInOutput', false);

and used here:

// Write to our output channel
if (levelEnabled(level)) {
this._channel.appendLine(user_message);
}

e.g.

// Write to our output channel 
if (levelEnabled(level)) {
    if (!debugInOutput) {
        this._channel.appendLine(user_message);
    } else {
        this._channel.appendLine(raw_message);
    }
} 
@github-project-automation github-project-automation bot moved this to Blocked in CMake Tools Sep 10, 2024
@v-frankwang v-frankwang added enhancement an enhancement to the product that is either not present or an improvement to an existing feature and removed triage labels Sep 11, 2024
@gcampbell-msft gcampbell-msft moved this from Blocked to Pending Prioritization in CMake Tools Oct 2, 2024
@gcampbell-msft gcampbell-msft added this to the Backlog milestone Oct 2, 2024
@gcampbell-msft gcampbell-msft added the more votes needed We currently are de-prioritizing this issue until more community up-votes are provided label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: UI more votes needed We currently are de-prioritizing this issue until more community up-votes are provided
Projects
Status: Pending Prioritization
Development

No branches or pull requests

3 participants