Add kit name selection by settings.json #3251
Conversation
|
@microsoft-github-policy-service agree |
|
@netkiss, we are reviewing and testing this PR. While we analyze this end to end, you can fix the linter errors that are reported. To reproduce them on your side, from your developer command prompt run "yarn run lint". The messages are quite explanatory but in case something is not clear don't hesitate to ask and we'll help. |
|
Ok, I will try to do it |
|
I have fixed linter errors |
|
Hi. Can I finish anything for feauture implementation? |
|
@netkiss, I reviewed and tested your PR and it works great. We had one concern if you can address. In case the kit pointed to by the new setting comes from the local kits file (.vscode/cmake-kits.json) instead of the user kits file (cmake-tools-kits.json from user folder) it would be a good to ask (just once) the user if they trust the kit. See PR #3067 for an example where something like this was implemented in a different scenario. |
|
Ok, I can do it |
There was a problem hiding this comment.
@netkiss Looking at the PR, it looks like it's still awaiting the changes requested by @andreeis here: #3251 (comment)
Could you make these changes?
|
@netkiss Until those changes are made, I've changed the PR to be in the "Draft" state to help us organize and prioritize PR's. Thanks! |
|
Due to the age of the PR and not having recent activity, I'm closing this PR. Please reopen if you want to continue working on this and want it merged. Thanks! |
This change addresses item #[[1496]]
This changes [[visible behavior]]
The following changes are proposed:
This pull request adds a way to set default kit name by cmake.defaultKitName parameter in the
"settings.json". If you will chose default kit name, you no longer have to manually select a kit
when opening a new folder.
Other Notes/Information
To set default kit you should add a kit to the ".vscode/cmake-kits.json" and the kit name to the
"settings.json" file. The behaviour will be the same if you will not set a default kit.