Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto select active project (#4146) #4151

Conversation

MNASTM
Copy link
Contributor

@MNASTM MNASTM commented Oct 30, 2024

This change addresses item #4146

This fixes the active project change behavior

The following change is proposed:

  • Update utils function isFileInsideFolder to avoid partial match and thus, wrong active project change

Contributed by STMicroelectronics
Signed-off-by: Matthieu NAUD matthieu.naud@st.com

@MNASTM MNASTM force-pushed the mnastm/fix-auto-select-active-project-4146 branch from a57fe6d to f1a5844 Compare October 30, 2024 12:02
@gcampbell-msft
Copy link
Collaborator

@MNASTM Looks like there are some linter errors, could you fix them so that the build succeeds?

@MNASTM MNASTM force-pushed the mnastm/fix-auto-select-active-project-4146 branch 2 times, most recently from 0895493 to e7f472c Compare November 4, 2024 11:47
gcampbell-msft
gcampbell-msft previously approved these changes Nov 4, 2024
@gcampbell-msft gcampbell-msft enabled auto-merge (squash) November 4, 2024 17:37
@gcampbell-msft
Copy link
Collaborator

@MNASTM Pinging about agreeing to the license agreement.

@MNASTM
Copy link
Contributor Author

MNASTM commented Nov 7, 2024

@MNASTM Pinging about agreeing to the license agreement.

I am in touch with my legal department and waiting for their approvals.

@gcampbell-msft
Copy link
Collaborator

@MNASTM Circling back on this, any updates?

Contributed by STMicroelectronics
Signed-off-by: Matthieu NAUD<matthieu.naud@st.com>
auto-merge was automatically disabled January 8, 2025 10:27

Head branch was pushed to by a user without write access

@MNASTM MNASTM force-pushed the mnastm/fix-auto-select-active-project-4146 branch from e7f472c to 7f1f68f Compare January 8, 2025 10:27
@MNASTM
Copy link
Contributor Author

MNASTM commented Jan 8, 2025

@microsoft-github-policy-service agree company="STMicroelectronics International N.V."

@MNASTM
Copy link
Contributor Author

MNASTM commented Jan 8, 2025

@MNASTM Circling back on this, any updates?

Just got the 'go' today and agreed the CLA

@MNASTM MNASTM requested a review from gcampbell-msft January 8, 2025 13:39
@gcampbell-msft gcampbell-msft enabled auto-merge (squash) January 8, 2025 14:48
@gcampbell-msft gcampbell-msft merged commit 1df786f into microsoft:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants