Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix_3598 #4206

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Fix_3598 #4206

merged 4 commits into from
Jan 6, 2025

Conversation

hippo91
Copy link
Contributor

@hippo91 hippo91 commented Dec 7, 2024

This change addresses item #3598

This changes visible behavior

The following changes are proposed:

  • Add optional argument to buildWithTarget method of the CMakeProject class;
  • Add optional argument to buildWithTarget method of the ExtensionManager class.

Other Notes/Information

This MR enable the use of a custom task that executes buildWithTarget command given an argument.
The video below show this:

BuildWithTarget.webm

Please note two things:

I did not add test for this. Please let me know if it is necessary.

@gcampbell-msft
Copy link
Collaborator

@hippo91 Overall, these changes look reasonable and look like they have very low risk for regressions. However, could you please add a CHANGELOG update and some screenshots or a video of how this works in the description? Thanks!

@hippo91
Copy link
Contributor Author

hippo91 commented Dec 21, 2024

@gcampbell-msft i added an entry in the CHANGELOG and modified the MR description, adding a video.

@gcampbell-msft gcampbell-msft merged commit 4a1d9c6 into microsoft:main Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants