-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use substituted config instead of raw #2485
base: main
Are you sure you want to change the base?
Conversation
See this link for details. https://code.visualstudio.com/api/references/vscode-api#DebugConfigurationProvider → resolveDebugConfigurationWithSubstitutedVariables This commit fixes the issue that variables in debug configs are not resolved. Using the proper VS Code API easily solves it.
How to test?Create a debug config as below and try to launch it.
Without the fix, msedge.exe will complain about non-existing user profile directory. With the fix, Microsoft Edge will launch with the customized user data directory as expected. |
@vidorteg please respond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uu
Contact UsName: Email: Phone Number: Message: <textarea required></textarea> Contact Us |
Hi @shanto, Thank you for the contribution, I'll take a look and reply back. |
See this link for details. https://code.visualstudio.com/api/references/vscode-api#DebugConfigurationProvider → resolveDebugConfigurationWithSubstitutedVariables
This commit fixes the issue that variables in debug configs are not resolved, and instead passed as-is to msedge.exe. Using the proper VS Code API easily solves it.
Before
After