Log best effort versions calculated for an environment (#22980)

For #22877
microsoft · Feb 27, 2024 · d0a07de · d0a07de
1 parent f1d7799
commit d0a07de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/client/pythonEnvironments/common/commonUtils.ts b/src/client/pythonEnvironments/common/commonUtils.ts
@@ -5,7 +5,7 @@ import * as fs from 'fs';
 import * as path from 'path';
 import { convertFileType, DirEntry, FileType, getFileFilter, getFileType } from '../../common/utils/filesystem';
 import { getOSType, OSType } from '../../common/utils/platform';
-import { traceError } from '../../logging';
+import { traceError, traceVerbose } from '../../logging';
 import { PythonVersion, UNKNOWN_PYTHON_VERSION } from '../base/info';
 import { comparePythonVersionSpecificity } from '../base/info/env';
 import { parseVersion } from '../base/info/pythonVersion';
@@ -246,8 +246,11 @@ export async function getPythonVersionFromPath(interpreterPath: string, hint?: s
         versionA = UNKNOWN_PYTHON_VERSION;
     }
     const versionB = interpreterPath ? await getPythonVersionFromNearByFiles(interpreterPath) : UNKNOWN_PYTHON_VERSION;
+    traceVerbose('Best effort version B for', interpreterPath, JSON.stringify(versionB));
     const versionC = interpreterPath ? await getPythonVersionFromPyvenvCfg(interpreterPath) : UNKNOWN_PYTHON_VERSION;
+    traceVerbose('Best effort version C for', interpreterPath, JSON.stringify(versionC));
     const versionD = interpreterPath ? await getPythonVersionFromConda(interpreterPath) : UNKNOWN_PYTHON_VERSION;
+    traceVerbose('Best effort version D for', interpreterPath, JSON.stringify(versionD));
 
     let version = UNKNOWN_PYTHON_VERSION;
     for (const v of [versionA, versionB, versionC, versionD]) {

diff --git a/src/client/terminals/envCollectionActivation/shellIntegrationService.ts b/src/client/terminals/envCollectionActivation/shellIntegrationService.ts
@@ -57,7 +57,6 @@ export class ShellIntegrationService implements IShellIntegrationService {
             }
             this.appShell.onDidWriteTerminalData(
                 (e) => {
-                    traceVerbose(e.data); // Log this temporarily for analysis
                     if (e.data.includes('\x1b]633;A\x07') || e.data.includes('\x1b]133;A\x07')) {
                         let { shell } = this.appEnvironment;
                         if ('shellPath' in e.terminal.creationOptions && e.terminal.creationOptions.shellPath) {