Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors when a linter crashes #20475

Closed
eternal-sorrow opened this issue Jan 5, 2023 · 3 comments
Closed

No errors when a linter crashes #20475

eternal-sorrow opened this issue Jan 5, 2023 · 3 comments
Assignees
Labels
area-linting bug Issue identified by VS Code Team member as probable bug

Comments

@eternal-sorrow
Copy link

eternal-sorrow commented Jan 5, 2023

Type: Bug

Behaviour

Expected vs. Actual

Expected: an error output or even a notification popup if a linter crashes
Actual: no output even in the "output" tab.

Steps to reproduce:

  1. Make a linter crash by any means. For example put an erroneous argument in the linter args. In my case it was --python-executable for mypy pointing to a non-existent path. Also I had a problem with a flake8 plugin which also led to a crash.
  2. Make any change to a python file which must trigger the linter to output a message.
  3. Don't get any linter messages and also no indication that the linter does not work.

Diagnostic data

  • Python version (& distribution if applicable, e.g. Anaconda): 3.10.6
  • Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
  • Value of the python.languageServer setting: Default
Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

Telemetry level is off
Experiments are disabled, only manually opted experiments are active.
LSP Notebooks experiment is disabled -- not using Pylance
LSP Notebooks interactive window support is disabled -- not in LSP Notebooks experiment
Python interpreter path: /usr/bin/python
Starting Jedi language server for Project.
Extension search path: /home/user/.local/share/vscode/extensions
> /usr/bin/python ~/.local/share/vscode/extensions/ms-python.python-2022.20.1-universal/pythonFiles/linter.py -m mypy --follow-imports=silent --ignore-missing-imports --show-column-numbers --no-pretty --python-executable=/not/exists/python ./file.py
cwd: .
##########Linting Output - mypy##########

User Settings


languageServer: "Jedi"

linting
• mypyArgs:
        "--show-column-numbers",
        "--no-pretty",
        "--disallow-untyped-decorators",
        "--check-untyped-defs",
        "--python-executable=env/bin/python"
• mypyEnabled: true

Extension version: 2022.20.1
VS Code version: Code - OSS 1.74.2 (e8a3071ea4344d9d48ef8a4df2c097372b0c5161, 2022-12-21T19:31:36.460Z)
OS version: Linux x64 6.0.12-zen1
Modes:
Sandboxed: No

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jan 5, 2023
@karthiknadig karthiknadig self-assigned this Jan 5, 2023
@karthiknadig
Copy link
Member

Thanks for the bug report! We investigate issues in order based on priority and severity, which includes the impact it has on your ability to use the extension to do productive work, and the number of people affected. If other users come forward and leave a comment demonstrating they are seeing/reproducing the problem then we will raise this issue's priority.

If you think your issue is more of a question or configuration problem rather than a bug, please ask on Stack Overflow with the visual-studio-code and python labels for help.

Thanks for your understanding and patience!

@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug area-linting needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Jan 6, 2023
@karthiknadig
Copy link
Member

@eternal-sorrow I recommend trying out the flake8 extension when working with a project that uses flake8. https://marketplace.visualstudio.com/items?itemName=ms-python.flake8 it is designed to better handle error scenarios.

@karthiknadig
Copy link
Member

The mypy extension https://marketplace.visualstudio.com/items?itemName=ms-python.mypy-type-checker has a setting showNotification that can be used to receive UI notification on errors. It also logs these errors in the extension's respective logs.

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
@github-actions github-actions bot removed the needs PR Ready to be worked on label Oct 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants