Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API to expose the tools such as Conda , PyEnv, etc #21732

Closed
DonJayamanne opened this issue Aug 2, 2023 · 4 comments
Closed

Add an API to expose the tools such as Conda , PyEnv, etc #21732

DonJayamanne opened this issue Aug 2, 2023 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality needs proposal Need to make some design decisions partner ask

Comments

@DonJayamanne
Copy link

Currenly the Jupyter Extension requires access to the Conda executable hence we have a private API that exposes

  • getCondaFile
  • getCondaVersion

Ideally just exposing the conda file would suffice, as the version can be derived from the executable.

Similarly I have an ask to expose this in my Python Environment manager, currently I need access to PyEnv, Conda, PipEnv, and other tools.

Given the fact that the tools are exposed in the envs, I think we can look into exposing the executable path as well via some API.

@DonJayamanne DonJayamanne added the feature-request Request for new features or functionality label Aug 2, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 2, 2023
@karthiknadig karthiknadig self-assigned this Aug 2, 2023
@karrtikr
Copy link

karrtikr commented Aug 3, 2023

Can you clarify on how APIs such as getCondaFile and getCondaVersion being used in Jupyter? Trying to check if an alternative like getActivatedEnvVars() API could potentially solve the problem instead.

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Aug 3, 2023
@DonJayamanne
Copy link
Author

No, that will not be sufficient as we use the conda executable to run conda commands like conda install.
Similarly my personal extensions run other commands like install/uninstall packages.

@github-actions github-actions bot removed the info-needed Issue requires more information from poster label Aug 3, 2023
@DonJayamanne DonJayamanne added info-needed Issue requires more information from poster partner ask labels Aug 3, 2023
@karrtikr karrtikr removed the info-needed Issue requires more information from poster label Aug 3, 2023
@karthiknadig karthiknadig removed their assignment Jan 18, 2024
@karthiknadig karthiknadig added needs proposal Need to make some design decisions and removed triage-needed Needs assignment to the proper sub-team labels Jan 18, 2024
@eleanorjboyd
Copy link
Member

Curious what here has been worked on or if the plan has changed with all the work in environments you have both worked on

@karthiknadig
Copy link
Member

karthiknadig commented Dec 11, 2024

There is dedicated API to do package installs, uninstalls, and checks. There is also an api to ask env managers to list installables in the project. APIs to create or remove environments. Those should be sufficient.

See: https://github.com/microsoft/vscode-python-environments?tab=readme-ov-file#api-reference-proposed

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality needs proposal Need to make some design decisions partner ask
Projects
None yet
Development

No branches or pull requests

4 participants