Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Activation tests are flaky #22264

Closed
karthiknadig opened this issue Oct 19, 2023 · 3 comments
Closed

Terminal Activation tests are flaky #22264

karthiknadig opened this issue Oct 19, 2023 · 3 comments
Labels
area-internal Label for non-user facing issues bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on

Comments

@karthiknadig
Copy link
Member

This test fails often and requires re-run. 

1) Activation of Environments in Terminal
       Should activate with virtualenv:

      Environment not activated
      + expected - actual

      -false
      +true
      
      at testActivation (out/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.js:75:74)
      at Context.<anonymous> (out/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.js:95:9)
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team area-internal Label for non-user facing issues labels Oct 19, 2023
@karrtikr karrtikr changed the title Extension Activation tests are flaky Terminal Activation tests are flaky Oct 19, 2023
@karrtikr karrtikr removed their assignment Oct 21, 2023
@karrtikr karrtikr added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Oct 21, 2023
@karrtikr
Copy link

karrtikr commented Oct 21, 2023 •
edited
Loading

Disabled these tests for now, we anyways have to test these a different way with the terminal activation experiment.

@eleanorjboyd
Copy link
Member

@anthonykim1 @karthiknadig - is this still the case?

@karthiknadig
Copy link
Member Author

We can close this, this will be handled in the new extension

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-internal Label for non-user facing issues bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karthiknadig @karrtikr @eleanorjboyd