Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading relative paths in settings in .code-workspace file #22472

Closed
karrtikr opened this issue Nov 13, 2023 · 4 comments
Closed
Labels
area-editor-* User-facing catch-all feature-request Request for new features or functionality

Comments

@karrtikr
Copy link

karrtikr commented Nov 13, 2023

When using ${workspaceFolder} or . notation in settings inside a .code-workspace file, For eg.

{
    "folders": [
        {
            "path": "notpython" // not a python folder
        },
        {
            "path": "python1" // the python folder that contains .pylintrc
        },
        {
            "path": "python2" // the python folder does NOT contain .pylintrc
        },
        {
            "path": "." // root workspace parent of both python1 and python2
        }
    ],
    "settings": {
        "pylint.args": ["--rcfile=${workspaceFolder}/.pylintrc"],
        "python.defaultInterpreterPath": "./.venv/bin/python"
    }
}

We should resolve that setting differently for each workspace folder. For eg. the value of that setting will be <path_to_notpython>/.pylintrc for first workspace folder, whereas <path_to_python1>/.pylintrc for the second one. Same goes when using . instead of ${workspaceFolder}.

cc/ @karthiknadig I'm not sure if we should resolve . for all settings, but at least for python.defaultInterpreterPath setting this seems ok

@karrtikr karrtikr added feature-request Request for new features or functionality area-editor-* User-facing catch-all needs community feedback Awaiting community feedback labels Nov 13, 2023
Copy link

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@karrtikr
Copy link
Author

This applies for all extensions and should be ideally supported by VS Code. We can transfer it upstream if needed based on the upvotes.

@karrtikr
Copy link
Author

Opened microsoft/vscode#198158 for the general support on VS Code.

@brettcannon
Copy link
Member

Thank you for submitting your feature request and everyone who considered it! Unfortunately, this issue did not receive enough votes over the allotted time, and so we are closing the issue.

@brettcannon brettcannon closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
@github-actions github-actions bot removed the needs community feedback Awaiting community feedback label Jan 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants