Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite execution error on imports that use shared filenames with the pythonFiles>unittestadapter directory #23098

Closed
shanesaravia opened this issue Mar 19, 2024 · 1 comment
Closed

Test suite execution error on imports that use shared filenames with the pythonFiles>unittestadapter directory #23098

shanesaravia opened this issue Mar 19, 2024 · 1 comment
Assignees
@karthiknadig @eleanorjboyd
Labels
area-testing triage-needed Needs assignment to the proper sub-team

Comments

@shanesaravia
Copy link

Type: Bug

Behaviour

Expected vs. Actual

Will fail to find some modules when trying to run the test suite. I already fixed this for "discovery" here: #22453. Had not realized it was an issue on execution as well until now.

Steps to reproduce:

  1. Run a test that has an import starting with "libs.____"

Diagnostic data

  • Python version (& distribution if applicable, e.g. Anaconda): 3.12.0
  • Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
  • Value of the python.languageServer setting: Default
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python) 

XXX

User Settings 


languageServer: "Pylance"

Extension version: 2024.2.1
VS Code version: Code 1.87.0 (019f4d1419fbc8219a181fab7892ebccf7ee29a2, 2024-02-27T23:42:51.279Z)
OS version: Darwin arm64 22.6.0
Modes:

System Info
Item Value
CPUs Apple M2 (8 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 4, 4, 5
Memory (System) 24.00GB (0.11GB free)
Process Argv --crash-reporter-id 4b723c15-099f-462d-9ad5-539b0c25d6c3
Screen Reader no
VM 0%
A/B Experiments 
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:30992800
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
pydisww2:30991134
cppperfnew:30979542
d34g3935:30971562
fegfb526:30981948
bg6jg535:30979843
ccp2r3:30993541
dsvsc020:30976470
666c4381:30973075
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 19, 2024
@shanesaravia shanesaravia changed the title Test suite execusion error on imports that use shared filenames with the pythonFiles>unittestadapter directory Test suite execution error on imports that use shared filenames with the pythonFiles>unittestadapter directory Mar 19, 2024
@shanesaravia shanesaravia mentioned this issue Mar 19, 2024
Merged
eleanorjboyd added a commit that referenced this issue Mar 29, 2024
@shanesaravia @eleanorjboyd
Resolve test suite execution import errors due to path ordering (#23099)
7c04ef2 
- This has already been discussed and resolved for tests discovery in
this [PR](#22454)
- I have now run into the same issue for executing the test suite and
have applied the same fix in this PR
- Tested and working

[Issue](#23098) for
this current PR

[Original
Issue](#22453)
[Original PR](#22454)

Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>
@karthiknadig
Copy link
Member

Fixed via #23099

wesm pushed a commit to posit-dev/positron that referenced this issue Apr 5, 2024
@shanesaravia @eleanorjboyd
Resolve test suite execution import errors due to path ordering (micr…
c7f1ac4 
…osoft/vscode-python#23099)

- This has already been discussed and resolved for tests discovery in
this [PR](microsoft/vscode-python#22454)
- I have now run into the same issue for executing the test suite and
have applied the same fix in this PR
- Tested and working

[Issue](microsoft/vscode-python#23098) for
this current PR

[Original
Issue](microsoft/vscode-python#22453)
[Original PR](microsoft/vscode-python#22454)

Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>
wesm pushed a commit to posit-dev/positron that referenced this issue Apr 8, 2024
@shanesaravia @eleanorjboyd @wesm
Resolve test suite execution import errors due to path ordering (micr…
a4a6cd1 
…osoft/vscode-python#23099)

- This has already been discussed and resolved for tests discovery in
this [PR](microsoft/vscode-python#22454)
- I have now run into the same issue for executing the test suite and
have applied the same fix in this PR
- Tested and working

[Issue](microsoft/vscode-python#23098) for
this current PR

[Original
Issue](microsoft/vscode-python#22453)
[Original PR](microsoft/vscode-python#22454)

Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karthiknadig karthiknadig

@eleanorjboyd eleanorjboyd

Labels
area-testing triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karthiknadig @shanesaravia @eleanorjboyd