Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to execute all the commands sent, without requiring manual 'Enter' keypress #24565

Open
anthonykim1 opened this issue Dec 9, 2024 · 0 comments
Assignees
Labels
area-repl bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on

Comments

@anthonykim1
Copy link

anthonykim1 commented Dec 9, 2024

Brought up: #24256 (comment)

During November iteration, we fixed indentation error for #24256

After the fix is merged, user is saying there are difference in how Run selection/line works for terminal -
In previous versions of Python extension, we executed all of the Python code that is sent to terminal, as opposed to mimicking REPL from cpython itself's behavior where it sometimes have trailing ... and requires an additional or two key presses of "Enter"

This is across all the different version of REPL in external terminal (using REPL from cpython):
Image

Since the command is "Run selection/line" we should aim to execute without having user to go down to terminal and press enter.

@anthonykim1 anthonykim1 added area-repl bug Issue identified by VS Code Team member as probable bug labels Dec 9, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Dec 9, 2024
@anthonykim1 anthonykim1 removed the triage-needed Needs assignment to the proper sub-team label Dec 9, 2024
@anthonykim1 anthonykim1 self-assigned this Dec 9, 2024
@anthonykim1 anthonykim1 added the needs PR Ready to be worked on label Dec 9, 2024
@anthonykim1 anthonykim1 changed the title Attempt to execute all the commands sent, without trailing ... in REPL Attempt to execute all the commands sent, without requiring manual 'Enter' keypress Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

1 participant