Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'coverage.exceptions.NoSource` import to fallback to previous exception path #24608

Merged
merged 3 commits into from
Dec 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions python_files/vscode_pytest/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,11 @@ def pytest_sessionfinish(session, exitstatus):
if is_coverage_run == "True":
# load the report and build the json result to return
import coverage
from coverage import exceptions

try:
from coverage.exceptions import NoSource
except ImportError:
from coverage.misc import NoSource

cov = coverage.Coverage()
cov.load()
Expand All @@ -462,7 +466,7 @@ def pytest_sessionfinish(session, exitstatus):
for file in file_set:
try:
analysis = cov.analysis2(file)
except exceptions.NoSource:
except NoSource:
# as per issue 24308 this best way to handle this edge case
continue
lines_executable = {int(line_no) for line_no in analysis[1]}
Expand Down
Loading