Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update associated issue check #24630

Closed
wants to merge 6 commits into from
Closed

update associated issue check #24630

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3c2ab5
update associated issue check
eleanorjboyd Dec 17, 2024
30e9739
update method
eleanorjboyd Dec 17, 2024
4a8c6dd
update how to add label
eleanorjboyd Dec 17, 2024
5c71846
write permissions
eleanorjboyd Dec 17, 2024
ac585c8
write privilege
eleanorjboyd Dec 17, 2024
c09dc73
take 3
eleanorjboyd Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/pr-file-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
- 'labeled'
- 'unlabeled'

permissions:
contents: read
pull-requests: write

jobs:
changed-files-in-pr:
name: 'Check for changed files'
Expand Down Expand Up @@ -41,11 +45,19 @@ jobs:
skip-label: 'skip tests'
failure-message: 'TypeScript code was edited without also editing a ${file-pattern} file; see the Testing page in our wiki on testing guidelines (the ${skip-label} label can be used to pass this check)'

- name: Add "issue-please" Label
uses: actions-ecosystem/action-add-labels@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
labels: 'issue-please'
- name: 'Ensure PR has an associated issue'
uses: actions/github-script@v6
with:
script: |
const labels = context.payload.pull_request.labels.map(label => label.name);
if (labels.includes('issue-please')) {
core.setFailed('The "issue-please" label is present. Please associate an issue and remove the label.');
}
if (!labels.includes('skip-issue-check')) {
const issueLink = context.payload.pull_request.body.match(/https:\/\/github\.com\/\S+\/issues\/\d+/);
if (!issueLink) {
Expand Down
Loading