fix read streams blocking node threads #24652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
added
the
bug
eleanorjboyd
approved these changes
Dec 23, 2024
karthiknadig
merged commit 00791fd
into
microsoft:release/2024.22
45 of 47 checks passed
|
Needs to be reopened @karthiknadig - Test Explorer in vscode with pytest broken since v2024.22.0. Tested v2024.22.1 - no change. This actually happens the moment one was more then 3 *_test.py files. |
|
This fixes a threading issue. Where, testing blocked all other extensions from loading. This is a different issue, see here #24656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24594
fixes #24507