The script under the system user continues to run after closing the terminal.

[KostyaTretyak]

• VSCode Version: 1.44.0
• OS Version: Linux x64 5.3.0-46-generic

Steps to Reproduce:

1. create index.js script for node server:

const http = require('http');

const server = http.createServer((req, res) => {
  res.end('OK');
});

server.listen(8080, () => {
  console.log('server work on http://localhost:8080');
});

2. in VS Code integrated terminal, login under system user, in my case it's node-user:

sudo -u node-user -Hs

3. run the script:

node index.js

4. from second terminal, check work:

curl -isS localhost:8080

response:

HTTP/1.1 200 OK
Date: Fri, 10 Apr 2020 07:37:15 GMT
Connection: keep-alive
Content-Length: 2

OK

5. kill first integrated terminal or close VS Code
6. check work and the script continues to work:

curl -isS localhost:8080

response:

HTTP/1.1 200 OK
Date: Fri, 10 Apr 2020 07:37:15 GMT
Connection: keep-alive
Content-Length: 2

OK

P.S. To kill the process, run:

sudo kill -9 `sudo lsof -t -i:8080`

[meganrogge]

I can reproduce the issue you're seeing when I run this first

sudo -u <my-username> -Hs

[meganrogge]

Not sure what -H does but this happens also if you just run sudo -u <my-username> -s IE when logged in, killing the terminal doesn't kill the process

[meganrogge]

here are the logs when I kill the terminal with the context menu action:

TRACE CommandService#executeCommand workbench.action.terminal.killInstance
workbench.desktop.main.js:601 TRACE terminalInstance#dispose (instanceId: 3)
workbench.desktop.main.js:601 DEBUG Terminal process exit (instanceId: 3) with code undefined
workbench.desktop.main.js:601 DEBUG Terminal process exit (instanceId: 3) state 5
workbench.desktop.main.js:601 TRACE terminalInstance#dispose (instanceId: 3)

state 5 just indicates killed by user

[meganrogge]

I believe this is an upstream node-pty issue

[meganrogge]

microsoft/node-pty#437

[jerch]

Thats actually expected behavior. The culprit behind is the sudo move - the POSIX permissions system is meant to disallow any process manipulations from an under privileged account, thus closing the PTY cannot clean sudo'ed child processes via SIGHUP.

[KostyaTretyak]

@jerch, if this is the expected behavior, then why doesn't it happen when we work, for example, with the default terminal for Ubuntu 20.04?

[jerch]

@KostyaTretyak I cannot tell you that. But have a few hints/remarks for that issue: In principle there are two ways to tear down a child process tree behind a PTY - first send the session leader (first program on the pty) SIGHUP by yourself. That signal will bubble through the children (if the session leader cooperates), but cannot pass the user permission border, as it was created by the user of the pty process. Thus the kernel wont deliver it to sudo'ed processes. A second more robust way is to let the kernel create that signal in the first place, e.g. by simply closing the PTY master end. That second method has one big advantage - it can cross user permission borders, since it comes from the kernel itself (who is allowed to do anything anyway).

So my guess is - vscode prolly uses method 1, while your default ubuntu terminal uses method 2 (or even both of them)?

[KostyaTretyak]

No, I think it's true bug, and it was not worth closing this issue.

[jerch]

Tried to give you an explanation to your "why..." question. In that context your "No, I think it's true bug" makes absolutely no sense without any further explanation from your side. Geez, why do I even care to explain things...

[KostyaTretyak]

@jerch, your explanation did not seem logical to me.