Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user when upgrading with fewer URLs #443

Open
Trenly opened this issue Sep 7, 2023 · 2 comments
Open

Warn user when upgrading with fewer URLs #443

Trenly opened this issue Sep 7, 2023 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage

Comments

@Trenly
Copy link
Contributor

Trenly commented Sep 7, 2023

Description of the new feature / enhancement

Not sure if this is a bug or a feature, but there were PR's for GoLang.Go created with fewer installer nodes.

While there are times that using fewer nodes is expected, such as when architectures are discontinued, these situations are fairly rare and should either throw a warning or only be valid in the interactive flow

Proposed technical implementation details

No response

@Trenly Trenly added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 7, 2023
@mdanish-kh
Copy link
Contributor

I think this is a case where the manifest was modified manually and later submitted through wingetcreate submit. wingetcreate update (both interactive and autonomous) only works when the number of new Installer Urls is the same as the number in the previous manifest (with the exception of msixbundles).

For this, we would need to query the repository in the submit flow and display a warning? / prompt user to really understand the consequences? Though I think the complete fix would be to handle it in microsoft/winget-pkgs#92688 (since even if the user accepts the warning, there's no way for a mod to know unless you manually see the previous manifest)

@Trenly
Copy link
Contributor Author

Trenly commented Sep 7, 2023

Ah, so this is really more related to

I assumed it was an issue with wingetcreate because the header said the manifests were created with wingetcreate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage
Projects
None yet
Development

No branches or pull requests

2 participants