Skip to content
Sonarcloud

Merge pull request #278 from microsoftgraph/feature/trimming #26

Sign in to view logs

Merge pull request #278 from microsoftgraph/feature/trimming

Merge pull request #278 from microsoftgraph/feature/trimming #26

Triggered via push November 9, 2023 01:29
@baywetbaywet
pushed 0b5ddfe
main
Status Success
Total duration 2m 34s
Artifacts –

sonarcloud.yml

on: push
check if SONAR_TOKEN is set in github secrets
0s
check if SONAR_TOKEN is set in github secrets
Build
2m 16s
Build
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Build: src/Microsoft.Graph.Cli.Core/Authentication/ClientCertificateCredentialFactory.cs#L41
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
Build: src/Microsoft.Graph.Cli.Core/Authentication/ClientCertificateCredentialFactory.cs#L76
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
Build: src/Microsoft.Graph.Cli.Core/Authentication/ClientCertificateCredentialFactory.cs#L32
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
Build: src/Microsoft.Graph.Cli.Core/Authentication/ClientCertificateCredentialFactory.cs#L40
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
Build: src/Microsoft.Graph.Cli.Core/Authentication/AppOnlyLoginService.cs#L13
'T' is not used in the class. (https://rules.sonarsource.com/csharp/RSPEC-2326)
Build: src/Microsoft.Graph.Cli.Core/Authentication/AuthenticationServiceFactory.cs#L21
Remove this unread private field 'authenticationOptions' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)
Build: src/Microsoft.Graph.Cli.Core/IO/GraphCliClientFactory.cs#L12
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
Build: src/Microsoft.Graph.Cli.Core/utils/Constants.cs#L8
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
Build: src/Microsoft.Graph.Cli.Core/utils/Constants.cs#L53
Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
Build: src/Microsoft.Graph.Cli.Core/utils/Constants.cs#L53
Change the visibility of 'TenantId' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223)