Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace /users/me with /me in middleware. #285

Merged
merged 25 commits into from
Nov 6, 2023

Conversation

calebkiage
Copy link
Collaborator

@calebkiage calebkiage requested a review from a team as a code owner November 1, 2023 00:02
baywet
baywet previously approved these changes Nov 2, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the changes

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@peombwa
Copy link
Member

peombwa commented Nov 3, 2023

@calebkiage, thanks for making the changes.

I believe you'll also need to add coverlet.msbuild package to your test project to generate the coverage result for Sonor Cloud:

    <PackageReference Include="coverlet.msbuild" Version="6.0.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>

This should address the 0 coverage result from SonarCloud. I recently delt with something similar.

baywet
baywet previously approved these changes Nov 3, 2023
@calebkiage
Copy link
Collaborator Author

@peombwa, I don't have that package in kiota-cli-commons and coverage works fine...see microsoft/kiota-cli-commons#86
@baywet, thoughts?

@baywet
Copy link
Member

baywet commented Nov 3, 2023

@calebkiage it used to be a requirement, which has probably changed. Are you able to get a coverage report when you build this locally?

@calebkiage
Copy link
Collaborator Author

calebkiage commented Nov 6, 2023

@peombwa, it turns out coverlet.msbuild is needed to use the /p:CollectCoverage=true msbuild integration. coverlet.collector is used with the coverlet command. I've updated the project to enable it. Thanks for the help :-)

Copy link

sonarcloud bot commented Nov 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

61.7% 61.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@calebkiage calebkiage merged commit 6fffc18 into main Nov 6, 2023
9 of 10 checks passed
@calebkiage calebkiage deleted the chore/replace-me-with-user-id branch November 6, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants