-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace /users/me
with /me
in middleware.
#285
Conversation
…eUriReplacement` boxing allocations. Cleanup code.
src/Microsoft.Graph.Cli.Core.Tests/Http/UriReplacement/MeUriReplacementTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Graph.Cli.Core.Tests/Http/UriReplacement/MeUriReplacementTests.cs
Outdated
Show resolved
Hide resolved
…placementTests.cs Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
…placementTests.cs Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
…crosoftgraph/msgraph-cli-core into chore/replace-me-with-user-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making the changes
Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
@calebkiage, thanks for making the changes. I believe you'll also need to add <PackageReference Include="coverlet.msbuild" Version="6.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference> This should address the 0 coverage result from SonarCloud. I recently delt with something similar. |
@peombwa, I don't have that package in kiota-cli-commons and coverage works fine...see microsoft/kiota-cli-commons#86 |
@calebkiage it used to be a requirement, which has probably changed. Are you able to get a coverage report when you build this locally? |
@peombwa, it turns out |
SonarCloud Quality Gate failed. 0 Bugs 61.7% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
microsoftgraph/msgraph-cli#349