Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update ESRP code signing config #435

Merged
merged 2 commits into from
Aug 15, 2024
Merged

ci: update ESRP code signing config #435

merged 2 commits into from
Aug 15, 2024

Conversation

calebkiage
Copy link
Collaborator

@calebkiage calebkiage commented Aug 7, 2024 •
edited
Loading

closes #437

@calebkiage calebkiage marked this pull request as ready for review August 9, 2024 13:08
@calebkiage calebkiage requested a review from a team as a code owner August 9, 2024 13:08
baywet
baywet approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to fail until CP-233863-SN gets deployed to our environment (should happen within the next few hours) but LGTM

@calebkiage calebkiage enabled auto-merge (squash) August 15, 2024 15:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@calebkiage calebkiage merged commit d716b6c into main Aug 15, 2024
9 checks passed
@calebkiage calebkiage deleted the ci/code-signing-update branch August 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate ESRPCodeSigning to v5
2 participants
@calebkiage @baywet