Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cd): add water_level and temperature option with customize lua_protocol #345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wuwentao
Copy link
Member

  1. add set customize option: lua_protocol, default is auto, user can manual set it to old or new, I'm not sure whether we will have more than two options, just use a str option for future.

for auto mode, use subtype and model to process current github issue known device.

  1. add water_level attribute, current only can display the raw value in debug log, I'm not sure the 4 level range now.
  2. add more attributes in debug log output, we can add it in future.

fix:
wuwentao/midea_ac_lan#347
wuwentao/midea_ac_lan#420
wuwentao/midea_ac_lan#425

@wuwentao wuwentao added this to the v6.0.4 milestone Dec 25, 2024
@github-actions github-actions bot added the enhancement New feature or request label Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 99 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
midealocal/devices/cd/__init__.py 0.00% 56 Missing ⚠️
midealocal/devices/cd/message.py 0.00% 43 Missing ⚠️
Files with missing lines Coverage Δ
midealocal/devices/cd/message.py 0.00% <0.00%> (ø)
midealocal/devices/cd/__init__.py 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant