Remove me #295
Closed
Remove me #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-lischke
requested changes
Aug 23, 2024
|
@mlshort Please sign the PR (see the DCO details link for an information how to do that). |
|
@mlshort Can you please fix the remaining issues soon (including the DCO)? I'd like to do a release this weekend. |
|
Note: I updated a few node modules myself, just enough to make the build green again. However, you have to rebase your patch now. |
No. I was not that insterested in doing a formal PR to begin with. I suggest you invoke |
mlshort
changed the title
|
fair enough, thanks |
mike-lischke
added a commit
that referenced
this pull request
Aug 25, 2024
- Refactored the context symbol table. Custom symbols now are in own files each. - Switched to newer eslint and fixed issues as suggested by PR #295. - Solved a number of recursive import problems. - Replaced 3rd party await-notify module (which has no type definitions) by an own implementation (Signal). Signed-off-by: Mike Lischke <mike@lischke-online.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.