Tweak cli. add --sbatch and --salloc as alternatives to --alloc and --persist #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
- Adds a --salloc flag which is exaclty the same as using the '--alloc' flag (without the --persist) flag. - Adds a --sbatch flag which is the same as doing --persist --alloc ... I think these are more naturally understood as the argument that are passed to `salloc` and `sbatch` respectively. Also, these two new args are in a mutually exclusive group with --persist. Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
force-pushed
the
tweak-cli-add-sbatch-salloc
branch
from
38d8096
to
1019a1e
Compare
satyaog
reviewed
May 14, 2024
satyaog
approved these changes
May 28, 2024
satyaog
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are more naturally understood as the argument that are passed to
sallocandsbatchrespectively.Also, these two new args are in a mutually exclusive group with --persist.