Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak cli. add --sbatch and --salloc as alternatives to --alloc and --persist #119

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Tweak cli. add --sbatch and --salloc as alternatives to --alloc and --persist #119

merged 6 commits into from
Jun 3, 2024

Commits on Apr 25, 2024

  1. Split mila function into chunks 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8bdec22 View commit details
    Browse the repository at this point in the history

  2. Make mila code default to mila code . 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1c37b40 View commit details
    Browse the repository at this point in the history

  3. Make the job_id an int instead of str 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    eff3fc2 View commit details
    Browse the repository at this point in the history

  4. Add --salloc and --sbatch flags (see desc.) 

    - Adds a --salloc flag which is exaclty the same as using the '--alloc'
  flag (without the --persist) flag.
- Adds a --sbatch flag which is the same as doing --persist --alloc ...

I think these are more naturally understood as the argument that are
passed to `salloc` and `sbatch` respectively.

Also, these two new args are in a mutually exclusive group with
--persist.

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    651937f View commit details
    Browse the repository at this point in the history

  5. Put the --alloc/--salloc/--sbatch args last 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4aacdb8 View commit details
    Browse the repository at this point in the history

  6. Add missing regression test file 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1019a1e View commit details
    Browse the repository at this point in the history