MT-55 Catch and handle Paramiko SSH errors #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a custom Exception class SSHConnectionError. Wraps Remote class with try except raise condition. Prints more explicit error message with possible workarounds instead of basic Exception error message which recommends to file a bug.
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
breuleux
reviewed
Jul 19, 2023
Comment on lines
+85
to
+87
| if keepalive: | ||
| connection.open() | ||
| connection.transport.set_keepalive(keepalive) |
There was a problem hiding this comment.
I'm not sure the SSHException will occur here if keepalive is not true. I think the connection object is lazy, so it may only open the connection on the first command we try to run. I don't remember if we ever set keepalive=0, so it may not matter in practice, but it's something to keep in mind.
breuleux
reviewed
Aug 22, 2023
Commit for code review suggestions Co-authored-by: Olivier Breuleux <breuleux@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a custom Exception class SSHConnectionError. Wraps Remote class with try except raise condition. Prints more explicit error message with possible workarounds instead of basic Exception error message which recommends to file a bug.