MT-60: Add a step to check the disk-quota in mila code
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
satyaog
approved these changes
Sep 18, 2023
satyaog
reviewed
Sep 18, 2023
milatools/cli/commands.py
Outdated
| max_files, | ||
| ) = last_line_parts.split("|") | ||
| used_gb = float(used_gb.removesuffix("GiB").strip()) | ||
| max_gb = float(max_gb.removesuffix("GiB").strip()) |
There was a problem hiding this comment.
str.removesuffix() has been added in python 3.9 I believe which is higher than the minimum stated in the pyproject.toml. Are we ok with bumping the minimal version to 3.9? I personally don't have any objections as mila tools is not likely to become a python packages dependency in any project.
Turns out I don't have a test for this, I got mixed up with #54 |
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
(not sure why or how it got removed in the first place tbh) Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
|
Merging, we'll add tests later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the disk usage before allocating a job.