-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MT-68] Add ControlMaster ssh options in mila init
#58
Merged
lebrice
merged 18 commits into
mila-iqia:master
from
lebrice:ControlMaster-mila-init-MT-68
Nov 1, 2023
Merged
[MT-68] Add ControlMaster ssh options in mila init
#58
lebrice
merged 18 commits into
mila-iqia:master
from
lebrice:ControlMaster-mila-init-MT-68
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes connecting to the cluster much easier, since the long delay will only happen on the first connection. Also makes it much quicker to reload a VsCode window connected to a compute node, for instance. Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
JulesGM
reviewed
Sep 25, 2023
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
breuleux
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControlMaster
,ControlPath
andControlPersist
options to themila
ssh configuration entry as well as the one used to connect to compute nodes.These options make it possible to reuse an existing ssh connection via what's called "SSH multiplexing". I'm not an expert, but basically, it seems to create a file in a predetermined path (set via
"ControlPath"
) for each "real" ssh connection. Then, if you try to make a new SSH connection to the same host and port, that initial connection is reused instead of making a new one.TL;DR: This makes it a LOT quicker to connect to the cluster or to compute nodes: after the first connection to the login node or compute node is done (still takes a while), the following connections are near-instant.
ALSO:
Removes extra newlines between SSH configuration entries
Improves the name and format of regression files used in unit tests. They are now readable Markdown files in this format:
(See https://github.com/lebrice/milatools/blob/ControlMaster-mila-init-MT-68/tests/cli/test_init_command/test_with_existing_entries_has_mila_compute_entry_has_mila_cpu_entry_no_mila_entry_.md for an example)