Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MT-68] Add ControlMaster ssh options in mila init #58

Merged
merged 18 commits into from
Nov 1, 2023
Merged

[MT-68] Add ControlMaster ssh options in mila init #58

merged 18 commits into from
Nov 1, 2023

Commits on Sep 25, 2023

  1. Add the ControlMaster/Path/Persist with mila init 

    This makes connecting to the cluster much easier, since the long delay
will only happen on the first connection. Also makes it much quicker to
reload a VsCode window connected to a compute node, for instance.

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    afa2ae7 View commit details
    Browse the repository at this point in the history

  2. Update unit tests for mila init 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2146187 View commit details
    Browse the repository at this point in the history

  3. Update regression files for mila init tests 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    3016707 View commit details
    Browse the repository at this point in the history

  4. Update the unit test for easier PR review 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    55ad8fa View commit details
    Browse the repository at this point in the history

  5. Rename the test parameter ids and fix content 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    5d992b0 View commit details
    Browse the repository at this point in the history

  6. Remove previous regression files 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    15c90b5 View commit details
    Browse the repository at this point in the history

  7. Add new regression files for mila init tests 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a9b244a View commit details
    Browse the repository at this point in the history

  8. Also improve format of other mila init test 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e0bc4a0 View commit details
    Browse the repository at this point in the history

  9. Remove the previous regression files 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b7d9df8 View commit details
    Browse the repository at this point in the history

  10. Add new regression files (and update content a bit) 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    cb31726 View commit details
    Browse the repository at this point in the history

  11. Remove duplicate newlines between config groups 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    46fd318 View commit details
    Browse the repository at this point in the history

  12. Update regression test files 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    91b2d95 View commit details
    Browse the repository at this point in the history

  13. Remove unused imports in test_init_command.py 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    91234b6 View commit details
    Browse the repository at this point in the history

  14. Add test case with extra empty lines 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d14f576 View commit details
    Browse the repository at this point in the history

  15. Add way to specify where to add empty lines 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c7d13df View commit details
    Browse the repository at this point in the history

  16. Add regression files for case with empty lines 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    79d3054 View commit details
    Browse the repository at this point in the history

  17. Remove comment 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c8c7261 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Fix isort 

    Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
    @lebrice
    lebrice committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    96b2de0 View commit details
    Browse the repository at this point in the history