internal: Improve mdx-loader usage. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesj
reviewed
Feb 8, 2024
boenrobot
force-pushed
the
mdxLoaderUpdate
branch
2 times, most recently
from
fad9565
to
d1eccac
Compare
…ions (specifically, the static folders and site dir). deps(mdx-loader): Explicitly require mdx loader as a peer dependency. deps(rimraf): Added rimraf as a dev dependency to enable cross platform removal of the tsconfig.lib.tsbuildinfo file, and thus cross platform builds. fix: Adjusted the whitelisting to only include files that are enabled, rather than include both if either changelogs or readmes are enabled. perf: Removed an unnecessary await in extractSidebar call.
boenrobot
force-pushed
the
mdxLoaderUpdate
branch
from
d1eccac
to
5f3b9c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly require mdx loader as an optional peer dependency.
Added rimraf as a dev dependency to enable cross platform removal of the tsconfig.lib.tsbuildinfo file, and thus cross platform builds.
Fix configuration to satisfy the mdx loader's options (specifically, the static folders and site dir).
Adjusted the whitelisting to only include files that are enabled, rather than include both if either changelogs or readmes are enabled.
Removed an unnecessary await in extractSidebar call.
I'm not 100% sure about the siteDir config, but then again, it's required, so something should be put there. Just not sure if copying the global siteDir is correct, or if some context/config/package specific folder is the correct path.