Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for Page Options - Hide Inherited [#150] #151

Merged
merged 4 commits into from
Sep 1, 2024

Conversation

rash805115
Copy link
Contributor

@rash805115 rash805115 commented Aug 3, 2024

This PR is to add support for page options, the first one including Hide Inherited as explained in #150 .

As shown in screenshot, at the top of the page you can see a new option - Page Options.


When unchecked (default), the page would show normally. Screenshot 2024-08-03 at 2 15 51 PM




When checked, all attributes that were inherited, in sidebar and in page content, are hidden.
Screenshot 2024-08-03 at 2 15 59 PM

@milesj
Copy link
Owner

milesj commented Aug 4, 2024

The functionality is nice but the placement of the UI needs work. Adds too much space.

@rash805115
Copy link
Contributor Author

Hmm I agree. What would you suggest? Maybe keep the Page Options div but make the actual options (next div) collapsible?
I was thinking if more options are ever added, they would be in line with the other options, so the height you see should not be more than what it is today.

@milesj
Copy link
Owner

milesj commented Aug 4, 2024

Maybe in the sidebar somewhere? Not sure if possible.

@rash805115
Copy link
Contributor Author

That was my first try, in the right sidebar.
But the UI was looking ugly, especially in mobile.

@rash805115 rash805115 changed the title feat: Support for Page Options - Hide Inherited [#50] feat: Support for Page Options - Hide Inherited [#150] Aug 4, 2024
@rash805115
Copy link
Contributor Author

I think I made it to sidebar, and it looks better than before for sure.

Look on mobile,
Screenshot 2024-08-04 at 10 25 48 AM

Look on desktop,
Screenshot 2024-08-04 at 10 26 06 AM

@rash805115
Copy link
Contributor Author

Hi @milesj Can you take a look when you have a chance?

@milesj
Copy link
Owner

milesj commented Aug 7, 2024

I'm out of town for the new few weeks.

@rash805115
Copy link
Contributor Author

Hello @milesj Just checking again if you are back in town, and if you can review this PR.

@milesj milesj merged commit 19c8bff into milesj:master Sep 1, 2024
9 of 10 checks passed
@rash805115 rash805115 deleted the #50-hide-inherited-option branch September 2, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants