-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix miss makezero bug #33386
fix: fix miss makezero bug #33386
Conversation
Welcome @alingse! It looks like this is your first PR to milvus-io/milvus 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alingse The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alingse Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@alingse Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
Signed-off-by: alingse <alingse@foxmail.com>
@alingse E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33386 +/- ##
==========================================
+ Coverage 82.12% 82.17% +0.04%
==========================================
Files 1012 1012
Lines 128862 128862
==========================================
+ Hits 105828 105892 +64
+ Misses 19061 18997 -64
Partials 3973 3973
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/reopen |
@alingse: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-cpu-e2e |
@alingse E2e jenkins job failed, comment |
/assign @xiaofan-luan |
@alingse E2e jenkins job failed, comment |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I was running github actions to run linter
makezero
for top github golang repos.see issues alingse/go-linter-runner#1
and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9241746915/job/25423640197