refactor: uniform all model names and correct many other text errors; #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-truthh
reviewed
Jul 6, 2023
| @@ -19,7 +19,7 @@ interpolation: "bilinear" | |||
| crop_pct: 0.875 | |||
|
|
|||
| # model | |||
| model: "shufflenet_v1_g3_x0_5" | |||
| model: "shufflenet_v1_g3_05" | |||
geniuspatrick
requested changes
Jul 11, 2023
| @@ -28,7 +28,7 @@ crop_pct: 0.935 | |||
| ema: True | |||
|
|
|||
| # model | |||
| model: 'crossvit15' | |||
There was a problem hiding this comment.
为什么有的数字前有下划线，有的之前没有
There was a problem hiding this comment.
跟ckpt的命名统一，有的ckpt文件名在之前修改的时候就没有加下划线
configs/densenet/README.md
Outdated
| | densenet_201 | D910x8-G | 78.14 | 94.08 | 20.24 | [yaml](https://github.com/mindspore-lab/mindcv/blob/main/configs/densenet/densenet_201_ascend.yaml) | [weights](https://download.mindspore.cn/toolkits/mindcv/densenet/densenet201-120_5004_Ascend.ckpt) | | ||
| | Model | Context | Top-1 (%) | Top-5 (%) | Params (M) | Recipe | Download | | ||
| |-------------|----------|-----------|-----------|------------|----------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------| | ||
| | densenet121 | D910x8-G | 75.64 | 92.84 | 8.06 | [yaml](https://github.com/mindspore-lab/mindcv/blob/main/configs/densenet/densenet121_ascend.yaml) | [weights](https://download.mindspore.cn/toolkits/mindcv/densenet/densenet121-120_5004_Ascend.ckpt) | |
| 'RepMLPNet_L256', | ||
| 'RepMLPNet_T224', | ||
| 'RepMLPNet_T256', | ||
| ['BiT_resnet50', |
There was a problem hiding this comment.
为了跟ckpt模型名对齐，没有改成小写
SamitHuang
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindCV repo.
Before submitting this PR, please make sure:
Motivation
统一库上模型名称
①模型名：configs目录下的子文件夹名（configs/*）与mindcv/models目录下的模型文件名（mindcv/models/*.py）保持一致；
②模型规格名：
__all__内模型名称、default_cfgs.keys()中的模型名称、@register_model处模型函数名model参数处模型名称以上模型名称保持一致（以ckpt文件名为准）；
其它修改
①修改过程中遇到的关联文件，如inference.md，readme.md等；
②configs/*/*.md的文章标题与论文中模型正式名称保持一致；
③benchmark_results.md；
④其他文本错误（如：GoogLENet ->GoogLeNet 等等）；
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)