fix bugs: fix some bugs in loading data #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XixinYang
approved these changes
Apr 25, 2024
(1)we should close() after open() (2)use meaningful variables (3)fixe some deep copy problems fix blow bugs: (1)we should close() after open() (2)use meaningful variables (3)fix some deep copy problems add empty line fix guides. change some code comments
geniuspatrick
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1)use with open() rather than open()
(2)use meaningful variables
(3)fix some deep copy problems
Thank you for your contribution to the MindCV repo.
Before submitting this PR, please make sure:
Motivation
修改了以下问题：
参数意义不明确
open 之后没有关闭
构造函数缺少传参，images_dir 地址拼写错误
深浅拷贝问题
最后读取后的数据每一个标签都关联上了所有的样本。
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)