Fix OpenSora 1.2 training #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaitinZhao
approved these changes
Aug 28, 2024
CaitinZhao
reviewed
Aug 28, 2024
| @@ -35,6 +35,8 @@ | |||
|
|
|||
|
|
|||
| class STDiT3Block(nn.Cell): | |||
| # to reduce compilation time | |||
| @ms.lazy_inline(policy="front") | |||
There was a problem hiding this comment.
vae的encoder和decoder也加下吧，解决动态shape OOM的问题
hadipash
approved these changes
Aug 30, 2024
| @@ -18,7 +18,7 @@ python scripts/train.py \ | |||
| --pretrained_model_path="models/OpenSora-STDiT-v3/opensora_stdit_v3.ckpt" \ | |||
| --mode=0 \ | |||
| --jit_level O1 \ | |||
| --max_device_memory 59GB \ | |||
| --max_device_memory 55GB \ | |||
SamitHuang
force-pushed
the
os1.2_stable_fix
branch
from
bf3b638
to
94cbbb4
Compare
HaoyangLee
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Set drop_remainder here to False as well to keep the consistency?
zhanghuiyao
approved these changes
Sep 13, 2024
SamitHuang
force-pushed
the
os1.2_stable_fix
branch
from
ba75c9d
to
a7a073f
Compare
SamitHuang
force-pushed
the
os1.2_stable_fix
branch
from
ada3f47
to
5c5e382
Compare
hadipash
approved these changes
Sep 24, 2024
vigo999
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Acceleration:
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx