Converting constructor removal; distinct types; thread-safe time access #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-topnotch
requested review from
balamurugana,
harshavardhana,
HJLebbink and
kobalicek
HJLebbink
approved these changes
Mar 19, 2024
HJLebbink
force-pushed
the
feature/hardening-2
branch
from
a1bdd6b to
621defa
Compare
|
@kobalicek Could you give it a thumbs up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the rework with the following improvements:
Response-derived types distinct to allow type-based template dispatching and dynamic type-aware switches (a.k.a. reflections) to work predictably.std::localtimeis not thread-safe. Replaced with localtime_r and localtime_s wrapped within a helper function hiding the OS implementation details.