Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📦 Add base image and initial features #7

Merged
merged 53 commits into from
Jan 30, 2024
Merged

📦 Add base image and initial features #7

merged 53 commits into from
Jan 30, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Jan 25, 2024 •
edited
Loading

This pull request:

  • Adds .devcontainer/devcontainer-lock.json (source)
  • Adds extensions
    • EditorConfig.EditorConfig
    • GitHub.vscode-github-actions
    • GitHub.vscode-pull-request-github
  • Updates EditorConfig
    • Sets indent style and size for shell scripts
    • Sets indent style and size for json and yaml
    • Disables end of line for .devcontainer/devcontainer-lock.json
  • Adds internal action for Install Google's Container Structure Test tool
  • Removes unused ecosystems from Dependabot
  • Adds devcontainers ecosystem to Dependabot
  • Adds GitLeaks configuration
  • Adds workflow for building, testing, validating and publishing features
  • Adds workflow for building, testing, scanning and publishing images
  • Adds features
    • aws
    • kubernetes
    • terraform
  • Adds base image
    • Extends dev container's Ubuntu base with a utility script
    • Extends dev container's theme to allow for prompt extension
    • Adds first run notice
    • Adds Container Structure Test
  • Adds script for building and testing images locally
  • Adds scripts for building, testing and debugging features locally
  • Adds script used by CI for generating path-filter configurations

Discussion about base image: #8

Signed-off-by: Jacob Woffenden jacob.woffenden@digital.justice.gov.uk

Add base image
651421a 
Add images workflow
Add path-filter generator

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden added the enhancement New feature or request label Jan 25, 2024
@jacobwoffenden jacobwoffenden self-assigned this Jan 25, 2024
Jacob Woffenden added 27 commits January 25, 2024 11:57
Fix broken YAML
88d8d5a 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Fix config generator
5baf9d2 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Fix workflow
9dd07c7 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Bump dorny/paths-filter to v3.0.0
6ca50ae 
Update config generator

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Update script path in workflow
ccef921 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Update EditorConfig
c747b97 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Rename to Dockerfile for Dependabot
b7d1102 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Update configuration generator
00f2e65 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add multi-arch matrix to build-and-test
0a9c667 
Tidy script

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add action
ec7e375 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Update uses
dd44344 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add devcontainer lockfile
e6524a7 
Add devcontainers ecosystem to Dependabot
Update action

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Fix template
e9ffa96 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add shell
0192464 
Update PATH

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Fix if
666312d 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
update run
e5f6a34 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
pinning at 1.16.0, 1.16.1 has no binaries
ca00cff 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
forgot to delete this
64efdce 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
debug
8009b37 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
im tired now
f3a5ff8 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add structure test
04844ec 
Add LABELs

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add image scanning
d3d1a01 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Remove platform flag
4ee5f61 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add newline to devcontainer lockfile
0bf4bfa 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
hide progress, it's noisy
e7a5fbe 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
add initial pre-flight check
b02042e 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
fix id-token
37876a7 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Jacob Woffenden added 23 commits January 25, 2024 19:22
fix variable
a8a405d 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
fix if
b6ee10b 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add newline
7d63af5 
Add README checking
ADD ONBUILD

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Fix workflow AGAIN
f72e91e 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
it's not README it's CHANGELOG
2dc89ff 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Update .editorconfig file
58af84e 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
SemVer for now
da03c2d 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add JSON and YAML to EditorConfig
298d82f 
Add feature testing workflow
Add AWS feature
Update base Dockerfile
Add first-run-notice
Update CST
Add feature test and debug scripts

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Fix workflow
e6b0e80 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Fix some linting stuff
a5a74fe 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Testing validation
144551c 
Add prompt theming

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Validate not on main
da7eac0 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Update base path to features
8010979 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Update base path to features/src
1f6707f 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Remove strategy
908396f 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Fix Dockerfile and hopefully shellcheck
b5dda2b 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Disable shellchecks
fa57952 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add Kubernetes and Terraform features
2b79bbd 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
linters
7be42ff 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add shellcheck exclusion
a6cf702 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add system upgrade to base
6509cf3 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add pre-flight to features
d17f6b3 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Adds feature publishing
cc2fef8 
Drops versions to 0.0.1

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden changed the title 📦 Add base image 📦 Add base image and initial features Jan 26, 2024
Update devcontainer feature path
8feb5a5 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden marked this pull request as ready for review January 30, 2024 17:17
@jacobwoffenden jacobwoffenden requested a review from a team as a code owner January 30, 2024 17:17
Gary-H9
Gary-H9 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gary-H9 Gary-H9 merged commit e00a38c into main Jan 30, 2024
28 checks passed
@Gary-H9 Gary-H9 deleted the feature/image-base branch January 30, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gary-H9 Gary-H9 Gary-H9 approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwoffenden @Gary-H9