fix(per): Ensure add another responses are rendered correctly #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlinc
reviewed
Oct 30, 2020
| @@ -611,7 +611,7 @@ describe('Presenters', function () { | |||
| { | |||
| value: test.value, | |||
| valueType: test.valueType, | |||
| responded: false, | |||
| responded: true, | |||
There was a problem hiding this comment.
Would it be worthwhile to have a test for the false value too?
There was a problem hiding this comment.
In this instance it should never actually be false. That was the issue. When this presenter is called, for the add another fields it should always set responded to true so that the value gets displayed.
cwrw
approved these changes
Oct 30, 2020
This passes a responded property to the framework response component for add another fields. The framework response component was updated to know about both responded and prefilled and now requires that the value be passed as true in order to render the value.
teneightfive
force-pushed
the
fix/add-another-responses
branch
from
10d22d8 to
8d5794e
Compare
|
Code Climate has analyzed commit 8d5794e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 97.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
This passes a responded property to the framework response component
for add another fields.
Why did it change
The framework response component was updated to know about both
responded and prefilled and now requires that the value be passed
as true in order to render the value.
Issue tracking
Checklists
Testing
Automated testing
Manual testing
Has been tested in the following browsers:
Environment variables
Other considerations
Commit messages with a
fixorfeattype are automatically used to generate the changelog andGitHub release notes during the release task. Please make sure they will read well on their own in a
summary of changes and that the commit body gives a more detailed description of those changes if necessary.