CCMSPUI-383 Modified endpoint to have required provider-id request pa…

…ram and updated tests to reflect this Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
ministryofjustice · Jan 14, 2025 · 060799e · 060799e
1 parent e623156
commit 060799e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/data-api/open-api-specification.yml b/data-api/open-api-specification.yml
@@ -406,16 +406,16 @@ paths:
           description: 'Not found'
         '500':
           description: 'Internal server error'
-  /{provider-firm-party-id}/cases:
+  /cases:
     get:
       tags:
         - cases
       summary: 'Get Cases'
       operationId: 'getCases'
       x-spring-paginated: true
       parameters:
-        - name: 'provider-firm-party-id'
-          in: 'path'
+        - name: 'provider-id'
+          in: 'query'
           required: true
           schema:
             type: 'integer'

diff --git a/data-service/src/test/java/uk/gov/laa/ccms/data/controller/CaseSearchControllerTest.java b/data-service/src/test/java/uk/gov/laa/ccms/data/controller/CaseSearchControllerTest.java
@@ -66,17 +66,26 @@ void getCases_returnsData() throws Exception {
         .thenReturn(Optional.of(caseDetails));
     // Then
     String jsonContent = objectMapper.writeValueAsString(caseDetails);
-    this.mockMvc.perform(get("/123/cases"))
+    this.mockMvc.perform(get("/cases?provider-id=123"))
         .andDo(print())
         .andExpect(status().isOk())
         .andExpect(content().json(jsonContent));
   }
 
+  @Test
+  @DisplayName("getCases: Returns bad request")
+  void getCases_returnsBadRequest() throws Exception {
+    // Then
+    this.mockMvc.perform(get("/cases"))
+        .andDo(print())
+        .andExpect(status().isBadRequest());
+  }
+
   @Test
   @DisplayName("getCases: Returns not found")
   void getCases_returnsNotFound() throws Exception {
     // Then
-    this.mockMvc.perform(get("/123/cases"))
+    this.mockMvc.perform(get("/cases?provider-id=123"))
         .andDo(print())
         .andExpect(status().isNotFound());
   }