-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/8674-tidyup #8970
Issue/8674-tidyup #8970
Conversation
…this is no longer used. As the variable itself in the module is not required, the version of the module can remain the same.
|
|
Terraform Plan Summarycore-shared-services-production |
1 similar comment
Terraform Plan Summarycore-shared-services-production |
Removes the INSTANCE_SCHEDULING_SKIP_ACCOUNTS variable assignment as this is no longer used. As the variable itself in the module is not required, the version of the module can remain the same.
A reference to the issue / Description of it
#8674
How does this PR fix the problem?
As above. Note that the Go source no longer relies on this environment variable so this removes it to avoid confusion.
There is no functional change to the operation of the instance scheduler - this is because the module has an empty default for the variable "environment_variables" and so it will handle that empty value as shown below:
https://github.com/ministryofjustice/modernisation-platform-terraform-lambda-function/blob/912834c4449af02c7f9191f1040262c17f0fb5f8/main.tf#L84
How has this been tested?
Please describe the tests that you ran and provide instructions to reproduce.
See unit tests below.
Deployment Plan / Instructions
Will this deployment impact the platform and / or services on it?
{Please write here}
Checklist (check
x
in[ ]
of list items)Additional comments (if any)
{Please write here}