Fix money routes processSelectedDate #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psoleckimoj
commented
Dec 4, 2023
| @@ -15,14 +21,22 @@ function isValidDateSelection(selectedDate, dateSelection) { | |||
| } | |||
|
|
|||
| function processSelectedDate(selectedDate) { | |||
| const dateSelection = getDateSelection(new Date(), parseISO(selectedDate)); | |||
| const parsedDate = parseISO(selectedDate); | |||
There was a problem hiding this comment.
I have no idea why this suddenly started to fail. The failing tests were calculating incorrect dates due to trying to use today's date with previous years causing a weird set of results. The underlying function getDateSelection is fine and allows for dependency injection but this cannot happen here due to it being a route that's being tested.
I have pulled the current year out of the selectedDate (if parsable) to make new Date() behave as if it's the year from the selectedDate rather than when the tests are run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
No.
Intent
date function allowed dependency injection so worked for testing, however code that used it did not allow dependency injection.
Considerations
Checklist