Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove some tests #693

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix/remove some tests #693

merged 1 commit into from
May 28, 2024

Conversation

psoleckimoj
Copy link
Contributor

Context

Does this issue have a Jira ticket?

No

If this is an issue, do we have steps to reproduce?

Sentry report https://ministryofjustice.sentry.io/issues/5411125793/?alert_rule_id=1210954&alert_timestamp=1716744980863&alert_type=email&environment=production&notification_uuid=d3d3cdf9-365b-415d-9b03-d1dce0e7cb22&project=5377056&referrer=alert_email

isInvalid method was not checking for undefined

Test updated.

Approved visitor tests removed as have been commented out for 3 years.

Intent

What changes are introduced by this PR that correspond to the above ticket?

Would this PR benefit from screenshots?

Considerations

Is there any additional information that would help when reviewing this PR?

Are there any steps required when merging/deploying this PR?

Checklist

  • This PR contains only changes related to the above ticket
  • Tests have been added/updated to cover the change
  • Documentation has been updated where appropriate
  • Tested in Development

Copy link
Contributor

@Eli-TW Eli-TW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@psoleckimoj psoleckimoj merged commit 9f8e5f0 into main May 28, 2024
7 of 8 checks passed
@psoleckimoj psoleckimoj deleted the feature/fix-some-tests branch May 28, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants