Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LNP-806: Prefix all page title with Content Hub - #695

Merged
merged 2 commits into from
Jun 7, 2024
Merged

LNP-806: Prefix all page title with Content Hub - #695

merged 2 commits into from
Jun 7, 2024

Conversation

psoleckimoj
Copy link
Contributor

@psoleckimoj psoleckimoj commented Jun 6, 2024 •
edited
Loading

Context

Does this issue have a Jira ticket?

Yes

If this is an issue, do we have steps to reproduce?

Intent

What changes are introduced by this PR that correspond to the above ticket?

Appends - Content Hub to all page titles.

Would this PR benefit from screenshots?

Considerations

Is there any additional information that would help when reviewing this PR?

Are there any steps required when merging/deploying this PR?

Checklist

  • This PR contains only changes related to the above ticket
  • Tests have been added/updated to cover the change
  • Documentation has been updated where appropriate
  • Tested in Development

@psoleckimoj psoleckimoj marked this pull request as ready for review June 6, 2024 14:14
@psoleckimoj psoleckimoj changed the title Prefix all page title with Content Hub - LNP-806: Prefix all page title with Content Hub - Jun 6, 2024
sweetymj
sweetymj approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@sweetymj sweetymj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@psoleckimoj psoleckimoj merged commit f3f9ca5 into main Jun 7, 2024
9 checks passed
@psoleckimoj psoleckimoj deleted the feature/prefix-all-titles branch June 7, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweetymj sweetymj sweetymj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psoleckimoj @sweetymj