Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LNP-868: Add profile feature switching per site #710

Merged
merged 28 commits into from
Aug 1, 2024
Merged

LNP-868: Add profile feature switching per site #710

merged 28 commits into from
Aug 1, 2024

Conversation

psoleckimoj
Copy link
Contributor

@psoleckimoj psoleckimoj commented Jul 23, 2024 •
edited
Loading

Context

Does this issue have a Jira ticket?

https://dsdmoj.atlassian.net/browse/LNP-868

If this is an issue, do we have steps to reproduce?

N/A

Intent

What changes are introduced by this PR that correspond to the above ticket?

  • Adds config to allow per site profile switching
  • Adds config to allow per site profile sections switch (currently adjudications, approved visitors, incentives, money, timetable, visits)
  • Removes existing global switching for approved visitors and adjudications
  • Removes existing per site switching for adjudications
  • Removes hardcoded references to berwyn

Would this PR benefit from screenshots?

No.

Considerations

Is there any additional information that would help when reviewing this PR?

No.

Are there any steps required when merging/deploying this PR?

No.

Checklist

  • This PR contains only changes related to the above ticket
  • Tests have been added/updated to cover the change
  • Documentation has been updated where appropriate
  • Tested in Development

psoleckimoj
psoleckimoj commented Jul 24, 2024
View reviewed changes
server/config.js Outdated Show resolved Hide resolved
sweetymj
sweetymj previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@sweetymj sweetymj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@psoleckimoj psoleckimoj marked this pull request as ready for review July 24, 2024 08:17
madebyzak
madebyzak previously approved these changes Jul 24, 2024
View reviewed changes
Copy link

@madebyzak madebyzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psoleckimoj psoleckimoj dismissed stale reviews from madebyzak and sweetymj via f78bfef July 24, 2024 12:15
@psoleckimoj psoleckimoj changed the title Feature/add profile feature switching per site LNP-868: Add profile feature switching per site Jul 25, 2024
madebyzak
madebyzak reviewed Jul 25, 2024
View reviewed changes
server/config.js Outdated Show resolved Hide resolved
Eli-TW
Eli-TW requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Eli-TW Eli-TW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor queries.

server/config.js Show resolved Hide resolved
server/views/pages/home-new.html Outdated Show resolved Hide resolved
Eli-TW
Eli-TW previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@Eli-TW Eli-TW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomeness

@psoleckimoj psoleckimoj requested a review from Eli-TW August 1, 2024 06:52
Eli-TW
Eli-TW requested changes Aug 1, 2024
View reviewed changes
server/config.js Show resolved Hide resolved
sweetymj
sweetymj approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@sweetymj sweetymj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@psoleckimoj psoleckimoj merged commit 65b4a2c into main Aug 1, 2024
7 of 8 checks passed
@psoleckimoj psoleckimoj deleted the feature/add-profile-feature-switching-per-site branch August 1, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweetymj sweetymj sweetymj approved these changes

@Eli-TW Eli-TW Eli-TW approved these changes

@madebyzak madebyzak Awaiting requested review from madebyzak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psoleckimoj @Eli-TW @madebyzak @sweetymj