Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update health endpoint to reflect other apps #736

Merged

Conversation

psoleckimoj
Copy link
Contributor

Context

Does this issue have a Jira ticket?

No.

If this is an issue, do we have steps to reproduce?

Intent

What changes are introduced by this PR that correspond to the above ticket?

This updates the output of the /health endpoint to match the standard used across frontend apps to help with status checking in the developer portal for the SRE and service teams.

Would this PR benefit from screenshots?

Considerations

Is there any additional information that would help when reviewing this PR?

Are there any steps required when merging/deploying this PR?

Checklist

  • This PR contains only changes related to the above ticket
  • Tests have been added/updated to cover the change
  • Documentation has been updated where appropriate
  • Tested in Development

@psoleckimoj psoleckimoj requested a review from madebyzak January 9, 2025 10:34
madebyzak
madebyzak previously approved these changes Jan 9, 2025
Copy link

@madebyzak madebyzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psoleckimoj psoleckimoj merged commit b2bf389 into main Jan 9, 2025
9 checks passed
@psoleckimoj psoleckimoj deleted the feature/update-health-info-endpoints-to-match-templates branch January 9, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants