Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNP-1112: Move to single deployment #740

Merged

Conversation

psoleckimoj
Copy link
Contributor

@psoleckimoj psoleckimoj commented Jan 15, 2025

Context

Does this issue have a Jira ticket?

Yes

If this is an issue, do we have steps to reproduce?

Intent

What changes are introduced by this PR that correspond to the above ticket?

It removes the multiple deployments in dev so there is a single deployment for a PR/branch as per other environments and products.

Would this PR benefit from screenshots?

No.

Considerations

Is there any additional information that would help when reviewing this PR?

No

Are there any steps required when merging/deploying this PR?

No.

Checklist

  • This PR contains only changes related to the above ticket
  • Tests have been added/updated to cover the change
  • Documentation has been updated where appropriate
  • Tested in Development

@psoleckimoj psoleckimoj marked this pull request as ready for review January 15, 2025 12:56
@@ -43,7 +43,7 @@ spec:
{{- end }}
{{- end }}
{{- with .Values.ingress.host }}
- host: {{ tpl .pattern (dict "qualifier" $.Values.ingress.qualifier "Template" $.Template) }}
- host: {{ tpl .pattern (dict "Template" $.Template) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think places where you do tpl but only pass it (dict "Template" $.Template) could be replaced with a direct reference to something in .Values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were the bits that blew up when I tried to directly replace as it was complaining about invalid values, maps etc.

host:
pattern: "prisoner-content-hub-development-{{ .qualifier }}.apps.live.cloud-platform.service.justice.gov.uk"
pattern: "prisoner-content-hub-development.apps.live.cloud-platform.service.justice.gov.uk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as there's no other references to variables in this it no longer needs to be a pattern/ or use tpl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that one, will try and sort next PR.

Copy link
Contributor

@andrewrlee andrewrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psoleckimoj psoleckimoj merged commit 6fd61f5 into main Jan 15, 2025
9 checks passed
@psoleckimoj psoleckimoj deleted the feature/feature/LNP-1112-move-to-single-deployment-for-dev-2 branch January 15, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants